Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062?usp=email )

Change subject: s1gw: derive functions from f_TC_e_rab_setup() ......................................................................

Patch Set 3:

(1 comment)

This change is ready for review.

File s1gw/S1GW_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38062/comment/16ad3e04_97ce0... : PS2, Line 328: for (var integer i := 0; i < lengthof(erabs); i := i + 1) {

You could actually split this for loop in a function which returns E_RABToBeSetupListBearerSUReq. […]

We can do that when we can re-use `E_RABToBeSetupListBearerSUReq` in other PDUs (e.g. in upcoming testcases for the `INITIAL CONTEXT SETUP REQUEST`). Unfortunately, the S1AP specs. defined in a way that each message type has its own specific IEs, even though the IE structure is almost identical. And for now there would be only one user per such IE-crafting function. Let's keep it as-is for now and get back to this idea later.