Attention is currently required from: jolly.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150 )

Change subject: Added BSC tests for terminating voice group calls ......................................................................

Patch Set 2:

(5 comments)

File bsc/BSC_Tests_ASCI.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/76b8265e_b42f3... PS1, Line 507: connect(call_conn:COORD, chan_conn:COORD);

the functions handlers will wait one second after starting. I hope this prevents the race condition.

Better add a comment here explaining that.

File bsc/BSC_Tests_ASCI.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/ea442c8a_fd696... PS2, Line 99: var boolean uplink_busy := false; I have the feeling these 2 uplink_busy and uplink_free can be merged into 1 bool.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/366e060f_29cfd... PS2, Line 395: pars.asci_test := ASCI_TEST_SETUP_OK; When I was talking into looking at possibly changing booleans to states I wasn't meaning these booleans, but the ones in f_tc_vgcs_vbs_setup() :/

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/a872d486_1ded4... PS2, Line 454: f_sleep(2.0); why these sleeps are being kept? Please if it's really needed, add a comment explaining why.

File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33150/comment/f32ae66a_ace42... PS2, Line 798: ASCITest asci_test I was fine with using booleans here before to tweak how the test code behaved. Maybe having an extra vgcs record with all those booleans, that's all.