Attention is currently required from: jolly.

View Change

5 comments:

• File bsc/BSC_Tests_ASCI.ttcn:

  • Patch Set #1, Line 507: connect(call_conn:COORD, chan_conn:COORD);

    the functions handlers will wait one second after starting. I hope this prevents the race condition.

    Better add a comment here explaining that.

• File bsc/BSC_Tests_ASCI.ttcn:

  • Patch Set #2, Line 99: var boolean uplink_busy := false;

    I have the feeling these 2 uplink_busy and uplink_free can be merged into 1 bool.

  • Patch Set #2, Line 395: pars.asci_test := ASCI_TEST_SETUP_OK;

    When I was talking into looking at possibly changing booleans to states I wasn't meaning these booleans, but the ones in f_tc_vgcs_vbs_setup() :/

  • Patch Set #2, Line 454: f_sleep(2.0);

    why these sleeps are being kept? Please if it's really needed, add a comment explaining why.

• File bsc/MSC_ConnectionHandler.ttcn:

  • Patch Set #2, Line 798: ASCITest asci_test

    I was fine with using booleans here before to tweak how the test code behaved. Maybe having an extra vgcs record with all those booleans, that's all.

To view, visit change 33150. To unsubscribe, or for help writing mail filters, visit settings.