Attention is currently required from: falconia, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32110 ) Change subject: common+trx: add rtp ecu-downstream vty option ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/32110/comment/a3ff9b45_3d88dfe2 PS3, Line 9: Current osmo-bts-trx includes a provision for invoking ECUs from : libosmocodec in the UL path from the channel decoder to the RTP : output; no other models currently do likewise, but there is no : particular reason why this ECU invokation couldn't be moved into : model-independent code. Some background knowledge: AFAIR, osmo-bts-sysmo (and hence liekly its relatives oc2g + lc15) already do some ECU magic in the DSP. Then some user discovered that audio sounded worse on -trx than on -sysmo, and they implemented the "provision for invoking ECUs" in -trx [only]. Patchset: PS1: I think rather than specifying that an ECU happens somewhere "downstream" I think it's more logical that the osmo-bts config file specifies what osmo-bts itself does. So let's rather name it in the inverse logic. something like "rtp builtin-ecu" or "rtp perform-ecu" or "rtp internal-uplink-ecu" would be most applicable in my understanding. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32110 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0acca9c6d7da966a623287563e0789db9e0fae8e Gerrit-Change-Number: 32110 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 10 May 2023 12:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment