Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31265 )
Change subject: gsm0808_enc/dec_channel_type: support data ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File include/osmocom/gsm/protocol/gsm_08_08.h:
https://gerrit.osmocom.org/c/libosmocore/+/31265/comment/7b674970_d7ae78a9 PS2, Line 503: /* GSM 08.08 3.2.2.11 Channel Type TS 48.008 everywhere?
File src/gsm/gsm0808_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/31265/comment/00583749_83fc424a PS2, Line 511: byte = ct->data_transparent ? 0x40 : 0x00; /* Set T/NT */ this looks a bit confusing. I'd be clearer probably: byte = ct->data_rate; if (ct->data_transparent) byte |= 0x40;
-
pespin