Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31265 ) Change subject: gsm0808_enc/dec_channel_type: support data ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File include/osmocom/gsm/protocol/gsm_08_08.h: https://gerrit.osmocom.org/c/libosmocore/+/31265/comment/7b674970_d7ae78a9 PS2, Line 503: /* GSM 08.08 3.2.2.11 Channel Type TS 48.008 everywhere? File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/c/libosmocore/+/31265/comment/00583749_83fc424a PS2, Line 511: byte = ct->data_transparent ? 0x40 : 0x00; /* Set T/NT */ this looks a bit confusing. I'd be clearer probably: byte = ct->data_rate; if (ct->data_transparent) byte |= 0x40; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib7b75c9d86aace329decf20003b68de459021c64 Gerrit-Change-Number: 31265 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Feb 2023 11:41:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment