Attention is currently required from: osmith.

Patch set 2:Code-Review +1

View Change

2 comments:

• File include/osmocom/gsm/protocol/gsm_08_08.h:

  • Patch Set #2, Line 503: /* GSM 08.08 3.2.2.11 Channel Type

    TS 48.008 everywhere?

• File src/gsm/gsm0808_utils.c:

  • Patch Set #2, Line 511: byte = ct->data_transparent ? 0x40 : 0x00; /* Set T/NT */

    this looks a bit confusing. I'd be clearer probably:
    byte = ct->data_rate;
    if (ct->data_transparent)
      byte |= 0x40;

To view, visit change 31265. To unsubscribe, or for help writing mail filters, visit settings.