Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34338?usp=email )
Change subject: stream_srv: Fix connection error handling ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/249e09a7_dcd5b25b PS2, Line 489: if (OSMO_UNLIKELY(res <= 0)) {
Because that's what osmo_stream_srv_destroy() does already (either through msgb_queue_free() or osmo […]
ah I see, `osmo_iofd_free()` -> `osmo_iofd_close()` -> `osmo_iofd_txqueue_clear()`, a bit different in logic from the lines after `case OSMO_STREAM_MODE_OSMO_FD:` in `stream_srv.c`.
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/6167639d_48828cf4 PS2, Line 494: conn How about logging an info message "Connection is being flushed and closed; will be ignoring any received messages from now on" only once in `osmo_stream_srv_set_flush_and_destroy()` (instead of for every received message after the flag has been set)?
I would upload a small patch for that.
https://gerrit.osmocom.org/c/libosmo-netif/+/34338/comment/b1473958_fa89f63b PS2, Line 496: if (osmo_iofd_txqueue_len(iofd) == 0)
I just noticed that osmo_stream_srv_clear_tx_queue() is not aware of osmo_io. I'll prepare a patch. […]
Done
-
arehbein