Attention is currently required from: neels, pespin, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28114 ) Change subject: switch from libdbi to lbsqlite3 ...................................................................... Patch Set 8: Verified+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/5a652f65_6ebad7d2 PS8, Line 7: WIP: switch from libdbi to lbsqlite3 it is not File include/osmocom/msc/db.h: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/030c5345_1b1e4a1a PS8, Line 43: int max_failed); no, it doesn't make sense. But the problem is if we pass an unsigned value, it may overflow the signed integer we're passing to sqlite3_bind_int(). There is no sqlite3_bind_uint() equivalent, and keeping it unsigned and passing UINT_MAX will lead to -1 causing failures in the related statements as attempts can never be < 0 .... File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/1d30102f_fb8b6a52 PS8, Line 489: break; Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia334904289f92d014e7bd16b02b3b5817c12c790 Gerrit-Change-Number: 28114 Gerrit-PatchSet: 8 Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith &lt;keith(a)rhizomatica.org&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: keith &lt;keith(a)rhizomatica.org&gt; Gerrit-Comment-Date: Tue, 17 May 2022 09:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: comment