Attention is currently required from: neels, pespin, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28114 )
Change subject: switch from libdbi to lbsqlite3 ......................................................................
Patch Set 8: Verified+1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/5a652f65_6ebad7d2 PS8, Line 7: WIP: switch from libdbi to lbsqlite3
Is it still WIP?
it is not
File include/osmocom/msc/db.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/030c5345_1b1e4a1a PS8, Line 43: int max_failed);
does it make sense to pass negative values here?
no, it doesn't make sense. But the problem is if we pass an unsigned value, it may overflow the signed integer we're passing to sqlite3_bind_int(). There is no sqlite3_bind_uint() equivalent, and keeping it unsigned and passing UINT_MAX will lead to -1 causing failures in the related statements as attempts can never be < 0 ....
File src/libmsc/db.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/1d30102f_fb8b6a52 PS8, Line 489: break;
wrong indentation
Done
-
laforge