Attention is currently required from: neels, pespin, keith.

Patch set 8:Verified +1

View Change

3 comments:

• Commit Message:

  • Patch Set #8, Line 7: WIP: switch from libdbi to lbsqlite3

    Is it still WIP?

    it is not

• File include/osmocom/msc/db.h:

  • Patch Set #8, Line 43: int max_failed);

    does it make sense to pass negative values here?

    no, it doesn't make sense. But the problem is if we pass an unsigned value, it may overflow the signed integer we're passing to sqlite3_bind_int(). There is no sqlite3_bind_uint() equivalent, and keeping it unsigned and passing UINT_MAX will lead to -1 causing failures in the related statements as attempts can never be < 0 ....

• File src/libmsc/db.c:

  • Patch Set #8, Line 489: break;

    wrong indentation

    Done

To view, visit change 28114. To unsubscribe, or for help writing mail filters, visit settings.