Attention is currently required from: laforge, pespin, keith.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )
Change subject: e1d: reconnect to osmo-e1d after connection loss ......................................................................
Patch Set 6:
(1 comment)
File src/input/e1d.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/045db258_dc82a082 PS4, Line 123: if (bfd->list.next && bfd->list.next != LLIST_POISON1)
no answer on this? I'd welcome if you checked my comments more carefully before submitting new versi […]
I always go through the whole patchset, fix all comments and then I push. I guess that is why sometimes comments slip through, but this is patchset 6 and the comment is from patchset 4 - i don't know.
The line if (bfd->list.next && bfd->list.next != LLIST_POISON1) can be found in many locations. I wonder why osmo_fd_unregister() does not do a osmo_fd_is_registered() internally. We should fix this in libosmocore first and then remove those checks here. Does this make sense?