Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584?usp=email )
Change subject: library/gsup: rework f_gen_{tr,ts}_ss_ies() and SS templates ......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/4c4cdf47_7ea34... : PS2, Line 1330: private function f_gen_ts_ss_ies(template (value) hexstring imsi,
You could split this big chunk of changes and move all the "(present)" and "(value)" into another pa […]
See https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38689.
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38584/comment/956ef41d_3cb1c... : PS3, Line 1415: else if (istemplatekind(destination_name, "*"))
TODO: separate commit
I moved this chunk to https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38585.