Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/33457
)
Change subject: osmo-bts-sysmo: mute PHY until OML is ready
......................................................................
Patch Set 8:
(1 comment)
File src/osmo-bts-sysmo/l1_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33457/comment/e1a013dd_12f608a6
PS7, Line 1271: oml_mo_rf_lock_chg(&trx->mo, fl1h->last_rf_mute, 0);
> did you check this is not sending StateChg before
SW_ACT OML messages are sent? […]
I meant call to the oml_mo_rf_lock_chg() function,
which also happens in the success case. IIUC without looking in detail that should trigger
a StateChg message on OML.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33457
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1769f952fa787202a442a33db5ed4a1f7cbe9c3
Gerrit-Change-Number: 33457
Gerrit-PatchSet: 8
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Jun 2023 16:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment