osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34018 )
Change subject: jobs: remove endianness check ......................................................................
jobs: remove endianness check
Related: OS#6122 Related: https://lists.osmocom.org/hyperkitty/list/openbsc@lists.osmocom.org/thread/O... Change-Id: I2358e6bc8189f9c5bdca10aac28032cb7a4667fa --- D jobs/gerrit-pipeline-endianness.yml M jobs/gerrit-verifications.yml 2 files changed, 11 insertions(+), 134 deletions(-)
Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified
diff --git a/jobs/gerrit-pipeline-endianness.yml b/jobs/gerrit-pipeline-endianness.yml deleted file mode 100644 index 19b9d61..0000000 --- a/jobs/gerrit-pipeline-endianness.yml +++ /dev/null @@ -1,110 +0,0 @@ -# This script runs struct_endianness.py from libosmocore.git. -# Add project's repositories to jobs/gerrit-verifications.yml. When -# pipeline_endianness is set for that project, the pipeline will call this job. - -- project: - name: gerrit-pipeline-endianness - jobs: - - 'gerrit-pipeline-endianness' - -- job: - name: 'gerrit-pipeline-endianness' - project-type: freestyle - node: osmocom-gerrit - retry-count: 3 # scm checkout - properties: - - build-discarder: - days-to-keep: 30 - num-to-keep: 1000 - description: | - Run <code>struct_endianness.py</code> from libosmocore.git on patches - sent to <a href="https://gerrit.osmocom.org">gerrit</a>. - </br></br> - Related issue: <a href="https://osmocom.org/issues/5884">OS#5884</a> - - parameters: - - string: - name: BRANCH_LIBOSMOCORE - description: | - libosmocore.git branch - default: 'master' - - string: - name: GERRIT_PROJECT - description: set by gerrit verification pipeline job - - string: - name: GERRIT_CHANGE_NUMBER - description: set by gerrit verification pipeline job - - string: - name: GERRIT_PATCHSET_NUMBER - description: set by gerrit verification pipeline job - - string: - name: GERRIT_BRANCH - description: set by gerrit verification pipeline job - - string: - name: GERRIT_HOST - description: set by gerrit verification pipeline job - - string: - name: GERRIT_PATCHSET_REVISION - description: set by gerrit verification pipeline job - - string: - name: GERRIT_PORT - description: set by gerrit verification pipeline job - - string: - name: GERRIT_REFSPEC - description: set by gerrit verification pipeline job - - string: - name: GERRIT_REPO_URL - description: set by gerrit verification pipeline job - - scm: - - git: - basedir: 'code-from-gerrit' - url: '$GERRIT_REPO_URL' - credentials-id: d5eda5e9-b59d-44ba-88d2-43473cb6e42d - branches: - - $GERRIT_BRANCH - refspec: $GERRIT_REFSPEC - choosing-strategy: gerrit - wipe-workspace: true - skip-tag: true - disable-submodules: true - - builders: - - shell: | - rm -rf libosmocore - git clone \ - --depth=1 \ - --branch="$BRANCH_LIBOSMOCORE" \ - https://gerrit.osmocom.org/libosmocore \ - libosmocore - git -C libosmocore log --oneline - - cd code-from-gerrit - ../libosmocore/contrib/struct_endianness.py - - case "$GERRIT_PROJECT" in - osmocom-bb) - # See https://gerrit.osmocom.org/c/osmocom-bb/+/31403 - EXCLUDE_ARG=":^src/shared/libosmocore" - ;; - esac - - git diff --color=always -- . $EXCLUDE_ARG - - if ! git diff --quiet -- . $EXCLUDE_ARG; then - set +x - echo '\033[1m' # bold font - echo "ERROR: auto-generated big-endian definitions missing or in unexpected format!" - echo - echo "Please run contrib/struct_endianness.py from libosmocore.git on your patch." - echo '\033[0m' # normal font - exit 1 - fi - wrappers: - - ansicolor: - colormap: xterm - - ssh-agent-credentials: - users: - - d5eda5e9-b59d-44ba-88d2-43473cb6e42d - -# vim: expandtab tabstop=2 shiftwidth=2 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index d2aaaae..c4e9e34 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -93,7 +93,6 @@ pipeline_build: true pipeline_lint: true pipeline_binpkgs: "almalinux:8 debian:10 debian:12" - pipeline_endianness: true
# in alphabetical order repos: @@ -107,7 +106,6 @@ - docker-playground: pipeline_build: false pipeline_binpkgs: "" - pipeline_endianness: false
- libasn1c - libgtpnl @@ -191,7 +189,6 @@ repos_url: '{gerrit_url}/erlang/{repos}' gerrit_project: 'erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - pipeline_endianness: false pipeline_binpkgs: "debian:10 debian:12"
- osmo-e1-hardware: @@ -214,7 +211,6 @@ - osmo-ci: pipeline_build: false pipeline_binpkgs: "" - pipeline_endianness: false
- osmo-ggsn: a1_name: GTP @@ -231,7 +227,6 @@ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh
- osmo-gsm-manuals: - pipeline_endianness: false pipeline_binpkgs: "debian:10 debian:12"
- osmo_gsup: @@ -293,7 +288,6 @@ - osmo-python-tests: repos_url: '{gerrit_url}/python/{repos}' gerrit_project: 'python/{repos}' - pipeline_endianness: false pipeline_binpkgs: "debian:10 debian:12"
- osmo-sgsn: @@ -315,7 +309,6 @@ gerrit_project: 'erlang/{repos}' cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' pipeline_binpkgs: "" - pipeline_endianness: false
- osmo-sip-connector
@@ -418,7 +411,6 @@ ;; esac pipeline_binpkgs: "" - pipeline_endianness: false
- osmo-ttcn3-hacks: slave_axis: !!python/tuple [ttcn3] @@ -436,7 +428,6 @@ su build -c 'make compile'; " pipeline_binpkgs: "" - pipeline_endianness: false
- dahdi-tools: pipeline_lint: false @@ -471,10 +462,6 @@ distributions must have binary packages in the osmocom:master repository. default: '{obj:pipeline_binpkgs}' - - bool: - name: PIPELINE_ENDIANNESS - description: Run struct_endianness.py from libosmocore.git - default: '{obj:pipeline_endianness}' dsl: | def run_job(display_name, job_name, comment_type=null, distro=null) {{ try {{ @@ -579,17 +566,6 @@ }} }}
- stage("Endianness") {{ - when {{ - expression {{ params.PIPELINE_ENDIANNESS }} - }} - steps {{ - script {{ - run_job("endianness", "gerrit-pipeline-endianness") - }} - }} - }} - }} // end of parallel }} // end of Verification stage