8 Jun
2023
8 Jun
'23
10:36 a.m.
Attention is currently required from: neels, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33169 )
Change subject: fix umts_cell_id_name(): show CID
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33169/comment/3b94c0a4_2fa9aa83
PS3, Line 12: Use OTC_SELECT
I personally suggest using stack-allocated buffers for
those cases where we don't have/want static buffers.
Agreed.
But I'm really surprised to hear any praise for
static buffers at all.
I thought that the consensus and aim is to get away from
static buffers
I'm not aware of such a notion/consensus. The heap allocated variants to me only make
sense in cases where they don't work for some specific reason.
Also, it is a big difference whether some function is called once (like to generate a fsm
name, or some other name of an object that has a certain lifetime) in a while, or a
function is called potentially thousands of times per second.
IIRC there is a log line that prints two distinct cell
IDs
If you know that, then I would suggest to special-case that one statement.
If you mean to imply that this is inefficient and
expensive related to the rest of osmo-hnbgw
I don't want to make such decisions specific to each and every program. The fact that
there may be some other horribly inefficient parts in osmo-hnbgw shouldn't be seen as
an excuse to introduce more *unless* there's a clear advantage.
Also, given that the user triggering this development is very keen on efficiency, and we
are currently spending an awful lot of time on osmo-bsc optimizations. Sooner or later I
expect the same will happen with osmo-hnbgw, as it gets loaded.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33169
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Id903b8579ded8b908e644808e440d373bcca8da4
Gerrit-Change-Number: 33169
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Jun 2023 08:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment