fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27700 )
Change subject: osmo-bts-trx: rx_tchf_fn(): clarify indexes in the AMR CMI lookup table ......................................................................
osmo-bts-trx: rx_tchf_fn(): clarify indexes in the AMR CMI lookup table
Change-Id: If81ff0bd449fe20da43cc3d96dadf38568507054 Related: SYS#5916 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 11 insertions(+), 4 deletions(-)
Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 9e88ce9..f886e59 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -45,11 +45,18 @@ #include <sched_utils.h> #include <loops.h>
-/* 3GPP TS 45.009, table 3.2.1.3-{1,3}: AMR on Uplink TCH/F */ +/* 3GPP TS 45.009, table 3.2.1.3-{1,3}: AMR on Uplink TCH/F. + * + * +---+---+---+---+---+---+---+---+ + * | a | b | c | d | e | f | g | h | Burst 'a' received first + * +---+---+---+---+---+---+---+---+ + * ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Speech/FACCH frame (bursts 'a' .. 'h') + * + * TDMA frame number of burst 'h' is always used as the table index. */ static const uint8_t sched_tchf_ul_amr_cmi_map[26] = { - [7] = 1, /* TCH/F: first=0 / last=7 */ - [16] = 1, /* TCH/F: first=8 / last=16 */ - [24] = 1, /* TCH/F: first=17 / last=24 */ + [7] = 1, /* TCH/F: a=0 / h=7 */ + [16] = 1, /* TCH/F: a=8 / h=16 */ + [24] = 1, /* TCH/F: a=17 / h=24 */ };
/*! \brief a single TCH/F burst was received by the PHY, process it */