Attention is currently required from: lynxis lazus, matanp, neels.
fixeria has posted comments on this change by matanp. (
https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email )
Change subject: vlr: Stop silent call before deduping subscribers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I tried to solve the problem more elegantly, but
making the VLR aware to the concept of silent calls […]
It feels architecturally
wrong to get the VLR involved in the MSC specific procedures, like the silent call.
Moreover, the VLR code is also going to be used by osmo-sgsn at some point, and changes
like this one will likely make the integration harder. I am not against merging this fix
as a workaround, but ideally we should look for a more fundamental approach.
Neels: Maybe you have any ideas?
P.S. Would be nice to have a bug reproducer in TTCN-3 and/or in form of a unit test.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd
Gerrit-Change-Number: 41131
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-Comment-Date: Thu, 18 Sep 2025 12:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>