Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39192?usp=email )
Change subject: pcap-server: remove unneeded check for null base_path
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/39192/comment/225121da_0b25f4db?us… :
PS1, Line 10: it can only be replaced with another string through VTY.
well, theoretically the talloc_strdup() in
osmo_talloc_replace_string() could fail, and return NULL. […]
That's definetly
not expected at all, and if that happened it would surely crash in 100 places more.
And in practice I doubt that will ever fail in linux, the process will simple be frozen
until the kernel can allocate more memory for it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39192?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I2f503f6f9af35d6ae6fbd03e85cade4f0eb93df2
Gerrit-Change-Number: 39192
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 24 Dec 2024 13:27:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>