Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39192?usp=email )
Change subject: pcap-server: remove unneeded check for null base_path ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/39192/comment/225121da_0b25f4db?usp... : PS1, Line 10: it can only be replaced with another string through VTY.
well, theoretically the talloc_strdup() in osmo_talloc_replace_string() could fail, and return NULL. […]
That's definetly not expected at all, and if that happened it would surely crash in 100 places more.
And in practice I doubt that will ever fail in linux, the process will simple be frozen until the kernel can allocate more memory for it.