7 Jul
2023
7 Jul
'23
2:01 p.m.
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33610 )
Change subject: ASCI: Add encoding of VGCS/VBS A-interface messages ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/osmo_bsc_bssap.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33610/comment/b5529bd1_b222f9d6 PS2, Line 1752: struct gsm0808_vgcs_vbs_setup_ack sa = { this looks a bit weird, for zero-initialized structs we usually use formatting "= {};" or "= {0};"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33610
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic2203a5119a226ac859a91dc42d81cbd71027ec8
Gerrit-Change-Number: 33610
Gerrit-PatchSet: 2
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Comment-Date: Fri, 07 Jul 2023 12:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment