Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly
......................................................................
kpi: Use HNB_CTR_RANAP_CS_RAB_REL_REQ(_ABNORMAL) explicitly
I was first tricked by the increment of ctr_num.
This is wrong for several reasons:
* Assumes one counter will always be immediatelly after the other, and
there's no static assert about that.
* Makes it difficult to grep for users of the counter in the code.
Change-Id: I126973b93e86784adaccbcba49c6322c261f4746
---
M src/osmo-hnbgw/kpi_ranap.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/78/40278/2
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/40278?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I126973b93e86784adaccbcba49c6322c261f4746
Gerrit-Change-Number: 40278
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder