Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email )
Change subject: asp: Introduce support to configure and enable TCP keep-alive ......................................................................
Patch Set 3:
(2 comments)
File src/ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/baf3a59c_9826b1... : PS2, Line 800: rc =
I did that on purpose, I don't want failure to set this make all fail, specially regarding SCTP INIT […]
I meant that the value was assigned but not used. I see you already fixed it.
File src/ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/49010837_8b8fb1... : PS3, Line 801:
This is already used in several places in our code base, check with: […]
Maybe do `(void)ss7_asp_apply_tcp_keepalive(...)` then? I find this cleaner. And I can see this pattern in several places, e.g. in libosmo-netif.git and osmo-ggsn.git.