Attention is currently required from: laforge, osmith, pespin.

View Change

2 comments:

• File src/ss7_asp.c:

  • Patch Set #2, Line 800: rc =

    I did that on purpose, I don't want failure to set this make all fail, specially regarding SCTP INIT […]

    I meant that the value was assigned but not used. I see you already fixed it.

• File src/ss7_asp.c:

  • Patch Set #3, Line 801:

    This is already used in several places in our code base, check with: […]

    Maybe do `(void)ss7_asp_apply_tcp_keepalive(...)` then? I find this cleaner. And I can see this pattern in several places, e.g. in libosmo-netif.git and osmo-ggsn.git.

To view, visit change 40481. To unsubscribe, or for help writing mail filters, visit settings.