Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28744 )
Change subject: trxcon: make l1sched logging configurable, append trxcon->fi prefix ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Do we really need the function callback, and to print trxcojn info when printing l1ched logging line […]
Yes, this is useful when trxcon has multiple L1CTL connections (ttcn3-bts-test will be using this soon) and thus multiple schedulers printing logging messages. We definitely need some way to distinguish them. Though, calling a function for each logging message may be an overkill. I think we can simply set a 'const char *prefix' to osmo_fsm_inst_name(trxcon->fi) without having the fsm state. What do you think?
File src/host/trxcon/src/sched_lchan_tchh.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28744/comment/2f0759b6_cff50f3d PS2, Line 185: #if 0
why is this commented out here?
Because no logging context is available here: neither sched, nor lchan.