Change in simtrace2[master]: firmware: bugfix: disable cardemu comms in local SIM mode

James Tavares has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26865 ) Change subject: firmware: bugfix: disable cardemu comms in local SIM mode ...................................................................... Patch Set 1: (2 comments) Thank you! Please let me know specifically what you would like changed. https://gerrit.osmocom.org/c/simtrace2/+/26865/1/firmware/libcommon/source/… File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/26865/1/firmware/libcommon/source/… PS1, Line 87: /*! real-time state of VCC I/O line, irrespective of enabled flag */ Understood, however in this case this commit changes the previously understood usage of some of these variables, and how they interact with each another, hence why I am documenting them. It would not make sense to submit a separate change request for just documentation. https://gerrit.osmocom.org/c/simtrace2/+/26865/1/firmware/libcommon/source/… PS1, Line 100: ; Per comment above, I believe these changes should be reviewed as one change request. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4010f988712eac4a6af8568ccd60062f9de62449 Gerrit-Change-Number: 26865 Gerrit-PatchSet: 1 Gerrit-Owner: James Tavares <jtavares(a)kvh.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 11 Jan 2022 18:29:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment