Patch Set 1: Code-Review+1

(2 comments)

nice catch, I think some minor cleanup would be appreciated.

Thank you! Please let me know specifically what you would like changed.

View Change

2 comments:

• File firmware/libcommon/source/mode_cardemu.c:

  • Patch Set #1, Line 87: /*! real-time state of VCC I/O line, irrespective of enabled flag */

    normally we would split this in a separate cosmetic patch only adding the comments, to keep it separ […]

    Understood, however in this case this commit changes the previously understood usage of some of these variables, and how they interact with each another, hence why I am documenting them. It would not make sense to submit a separate change request for just documentation.

  • Patch Set #1, Line 100: ;

    indeed, it is hard to see that an actual flag was added, because the reviewer (at least I in my firs […]

    Per comment above, I believe these changes should be reviewed as one change request.

To view, visit change 26865. To unsubscribe, or for help writing mail filters, visit settings.