[XL] Change in osmo-pcu[master]: support for Ericsson RBS E1 CCU

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31176 ) Change subject: support for Ericsson RBS E1 CCU ...................................................................... Patch Set 11: (7 comments) File src/ericsson-rbs/er_ccu_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/b8bb4af7_ec3131d1 PS11, Line 130: } void function return statements are not generally useful Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/cd2b24dc_1b561259 PS11, Line 236: if (!ccu_descr->trau_sync_fi) { braces {} are not necessary for single statement blocks File src/ericsson-rbs/er_ccu_l1_if.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/72fe268e_6bef2ff2 PS11, Line 241: "afn_ul=%u (computed) != afn_ul=%u (sync-ind) => delta=%u \n", afn_ul, unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/b3214d90_f01bcd22 PS11, Line 244: afn_ul)); Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_ul' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/ec96a20b_4c9e9672 PS11, Line 247: "afn_dl=%u (computed) != afn_dl=%u (sync-ind) => delta=%u \n", afn_dl, unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/1e8a600d_a7bc519e PS11, Line 250: afn_dl)); Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_dl' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995): https://gerrit.osmocom.org/c/osmo-pcu/+/31176/comment/da736dc8_4efb1ea9 PS11, Line 304: /* We do not receive sync indications in every cycle. When traffic is transfered we won't get frame numbers 'transfered' may be misspelled - perhaps 'transferred'? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5c0a76667339ca984a12cbd2052f5d9e5b0f9c4d Gerrit-Change-Number: 31176 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 24 Feb 2023 16:21:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment