7 comments:
File src/ericsson-rbs/er_ccu_if.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
Patch Set #11, Line 236: if (!ccu_descr->trau_sync_fi) {
braces {} are not necessary for single statement blocks
File src/ericsson-rbs/er_ccu_l1_if.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
Patch Set #11, Line 241: "afn_ul=%u (computed) != afn_ul=%u (sync-ind) => delta=%u \n", afn_ul,
unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
Patch Set #11, Line 244: afn_ul));
Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_ul'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
Patch Set #11, Line 247: "afn_dl=%u (computed) != afn_dl=%u (sync-ind) => delta=%u \n", afn_dl,
unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
Patch Set #11, Line 250: afn_dl));
Avoid multiple line dereference - prefer 'trau_frame.u.ccu_sync_ind.afn_dl'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3995):
Patch Set #11, Line 304: /* We do not receive sync indications in every cycle. When traffic is transfered we won't get frame numbers
'transfered' may be misspelled - perhaps 'transferred'?
To view, visit change 31176. To unsubscribe, or for help writing mail filters, visit settings.