Attention is currently required from: keith, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16808 )
Change subject: Add vty `reject-cause` to set the reject cause ......................................................................
Patch Set 11: Code-Review+2
(5 comments)
Patchset:
PS6:
CR-1 for incomplete command description. […]
Done
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/f3deb0b1_35c2f6af PS4, Line 85: get_value_string_or_null
We should not get NULL if everything is correct I think.
Done
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/70fe5a9a_2f73a111 PS4, Line 356: imsi unknown cause
Given that you're adding a value-string array now, it would be better to generate the command and he […]
Done
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/982d00c0_09315dd9 PS4, Line 357: GSUP cause
Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is.
Done
File src/hlr_vty.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/16808/comment/262e98ac_6b0de870 PS6, Line 381: imsi unknown cause
Here I would recommend concatenating all three words using '-', i.e. 'imsi-unknown-cause'. […]
Done