Attention is currently required from: keith, lynxis lazus.
Patch set 11:Code-Review +2
5 comments:
Patchset:
CR-1 for incomplete command description. […]
Done
File src/hlr_vty.c:
Patch Set #4, Line 85: get_value_string_or_null
We should not get NULL if everything is correct I think.
Done
Patch Set #4, Line 356: imsi unknown cause
Given that you're adding a value-string array now, it would be better to generate the command and he […]
Done
Patch Set #4, Line 357: GSUP cause
Saying GSUP/GMM is an option ;) But I don't want to block you here, so you can keep this as is.
Done
File src/hlr_vty.c:
Patch Set #6, Line 381: imsi unknown cause
Here I would recommend concatenating all three words using '-', i.e. 'imsi-unknown-cause'. […]
Done
To view, visit change 16808. To unsubscribe, or for help writing mail filters, visit settings.