Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email )
Change subject: ASCI: Make neigh_list_get_arfcn() available to other users
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/osmo-bsc/gsm_04_08_rr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34625/comment/63b17781_62a80624
PS2, Line 946: rc
you're changing the behavior here:
* currently `mrc->arfcn` is set to 0 on error;
* in your patch a negative value is set (`-EINVAL` casted to unsigned).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34625?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia8a1dca4837536129d17e7784b892bcb75b9ca4b
Gerrit-Change-Number: 34625
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 04 Oct 2023 13:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment