Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085 )
Change subject: hnbgw: add HNBAP port to ConnHdlr ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31085/comment/66df24a6_1f88e... PS1, Line 414: /* disconnect test_CT HNBAP[i], instead connect ConnHdlr.HNBAP to HNBAP[i] */
Isn't this breaking existing tests which used test_CT HNBAP[i] ?
Usually you have the test logic either in the test_CT or in the ConnHdlr. Why would this break the test_CT ones? With this patch applied, the ConnHdlr spawned by this function gets exclusive access to one of the HNBAP ports (determined by pars.hnb_idx). Leaving an HNBAP port connected to the test_CT would require all HNBAP.send() operations to use explicit addressing...