laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/26842 )
Change subject: icE1usb fw: Don't prefill feedback ......................................................................
icE1usb fw: Don't prefill feedback
This prevents inlining of the code, and is completely unecessary.
(1) It will be filled a bit later (2) We don't have any meaningful feedback to provide anyway
Signed-off-by: Sylvain Munaut tnt@246tNt.com Change-Id: I6e97bc79d1fe50950bb1f7cd71d8c428e928d4ae --- M firmware/ice40-riscv/icE1usb/usb_e1.c 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/firmware/ice40-riscv/icE1usb/usb_e1.c b/firmware/ice40-riscv/icE1usb/usb_e1.c index a18ebe4..032eec8 100644 --- a/firmware/ice40-riscv/icE1usb/usb_e1.c +++ b/firmware/ice40-riscv/icE1usb/usb_e1.c @@ -323,9 +323,6 @@ ep_regs->bd[0].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(292); ep_regs->bd[1].csr = USB_BD_STATE_RDY_DATA | USB_BD_LEN(292);
- /* EP Feedback: Pre-fill */ - _usb_fill_feedback_ep(port); - break; }