Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-msc/+/38654?usp=email )
Change subject: Use new libosmo-sigtran APIs to access osmo_ss7_instance
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
Feel free to CR+2 and merge after adding `const`.
File src/osmo-msc/msc_main.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38654/comment/07a6122a_c7ad9083?usp… :
PS2, Line 628: struct osmo_ss7_instance *ss7
can be `const`?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/38654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4c4f833cfcc4e65ee5372e7736dbef9c65c2f3de
Gerrit-Change-Number: 38654
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 08 Nov 2024 15:26:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes