pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 )
Change subject: llc: Log rx PDUs with invalid FCS ......................................................................
llc: Log rx PDUs with invalid FCS
Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 --- M src/llc/llc.c 1 file changed, 12 insertions(+), 2 deletions(-)
Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
diff --git a/src/llc/llc.c b/src/llc/llc.c index cff6c16..be1ebec 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -844,8 +844,9 @@ if (~pdu_dec->flags & OSMO_GPRS_LLC_PDU_F_PROT_MODE) crc_length = OSMO_MIN(crc_length, UI_HDR_LEN + N202); if (pdu_dec->fcs != gprs_llc_fcs(ll_pdu, crc_length)) { - LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x\n", - pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length)); + LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x: %s\n", + pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length), + osmo_hexdump(ll_pdu, ll_pdu_len)); return -EIO; }