Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34144 )
Change subject: osmo_io: Avoid potential double free when sending msgb ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I'm fine with this, but I'd like to get some feedback on my last proposal regarding somehow relating […]
Not sure if I understood you correctly.
For the receive side: In the poll backend the msghdr is only a local variable that goes out of scope as soon as iofd_poll_ofd_cb_recvmsg_sendmsg() returns, in io_uring the msghdr is free()d at the end of iofd_uring_handle_recv(). In both cases I expect the user might want to keep msg around for longer.
Then there's msg->pending which is a msg from (a/multiple) previous receive call so it's not clear what msghdr(s) it belongs to anymore.