[S] Change in osmo-bts[master]: ASCI: Retrieve NCH position from System Information 1

Attention is currently required from: osmith, fixeria, pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33296 ) Change subject: ASCI: Retrieve NCH position from System Information 1 ...................................................................... Patch Set 7: (2 comments) File src/common/sysinfo.c: https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/d7e2b2eb_eda4740d PS6, Line 177: /* H <NCH Position : bit (5)> */ Done https://gerrit.osmocom.org/c/osmo-bts/+/33296/comment/58314759_bee0df0d PS6, Line 180: return -EINVAL; An error message makes no sense, because having no NCH support is not an error. I changed it to -ENOTSUP. This makes more sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I799a27179d478d4ff577d8bc47ae524834851e85 Gerrit-Change-Number: 33296 Gerrit-PatchSet: 7 Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt; Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Comment-In-Reply-To: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-MessageType: comment