Attention is currently required from: daniel, lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: Add Routing Areas ......................................................................
Patch Set 15:
(3 comments)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/f6d1087d_006a8b62?usp... : PS15, Line 1: /* SGSN Routing Area for 2G */ missing a copyright header
File tests/gprs_routing_area/gprs_routing_area_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/41c9264b_24312cf9?usp... : PS15, Line 329: static struct log_info_cat gprs_categories[] = { Do we really need all these logging categories for the test? Why you are not adding DRA here?
File tests/testsuite.at:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/cbd78f7c_56d38119?usp... : PS15, Line 21: ignore Why not matching expected stderr too?