Attention is currently required from: arehbein.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )
Change subject: WIP: vty: Add check against sensible default value for Ny1
......................................................................
Patch Set 7:
(2 comments)
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2032):
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/7012e4c7_cc63112b
PS7, Line 127: static unsigned long const T3105_TESTVAL = 13;
Move const after static - use 'static const unsigned long'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2032):
https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/11b288e9_1ca9f204
PS7, Line 130: static unsigned long const NY1_TESTVAL = (GSM_T3124_MAX +
GSM_NY1_REQ_DELTA)/T3105_TESTVAL + 1;
Move const after static - use 'static const unsigned long'
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/30602
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089
Gerrit-Change-Number: 30602
Gerrit-PatchSet: 7
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 17 Dec 2022 15:26:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment