Attention is currently required from: laforge, pespin, Christian Amsüss, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/29033
)
Change subject: Add new pySim.ota library, implement SIM OTA crypto
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
so somewhere in the changes from 5 -> 7 we have a regression in the command encoding.
I yet have to figure out where this is coming from. I don't see any changes other than
the PCNT?
======================================================================
FAIL: test_cmd_3des_ciphered (test_ota.Test_SMS_3DES)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/space/home/laforge/projects/git/pysim/tests/test_ota.py", line 71, in
test_cmd_3des_ciphered
self.assertEqual(b2h(r),
'00180d04193535b000000c8478b552a4ffc5a8f099b83cad7123')
AssertionError: '00180d04193535b00000e3ec80a849b554421276af3883927c20' !=
'00180d04193535b000000c8478b552a4ffc5a8f099b83cad7123'
- 00180d04193535b00000e3ec80a849b554421276af3883927c20
+ 00180d04193535b000000c8478b552a4ffc5a8f099b83cad7123
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/29033
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84
Gerrit-Change-Number: 29033
Gerrit-PatchSet: 7
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 21 Aug 2022 11:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment