Attention is currently required from: keith.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email )
Change subject: trau_frame: add support for config frames of 3GPP Rel5+
......................................................................
Patch Set 1:
(1 comment)
File src/trau/trau_frame.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/41210/comment/4e390bd5_1f568ee5… :
PS1, Line 1371: * exception of newly added OSMO_TRAU16_FT_CONFIG, and for
OSMO_TRAU8_SPEECH
This comment will not age well. […]
The last
time 3GPP defined a new frame type for GSM Abis was Release 5 (2002); the newly added
frame type was the one in this patch. There have been no changes to TS 48.060 and 48.061
specs between Rel5 and the latest Rel18 - do you seriously expect any standards body to
add another frame type to a 2G-specific, E1-specific spec?
With the present patch, Osmocom trau_frame layer supports all TRAU frame types that have
ever been defined by 3GPP or its predecessors. I really don't expect there to be any
new ones.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ifbde07e4a3fb80e4faa0b6a6b32938ed98371c5b
Gerrit-Change-Number: 41210
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith(a)rhizomatica.org>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Sat, 11 Oct 2025 05:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>