Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32552 )
Change subject: osmo-bts-trx: fix trx_ctrl_read_cb(): do not send CMDs twice
......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bts-trx/trx_if.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32552/comment/c381a351_47a48f80
PS1, Line 737:
what about moving "trx_ctrl_send(l1h);" here
before call to trx_ctrl_rx_rsp()? this way we don't get […]
I was thinking about
this too. But this would make the logging/flow a bit confusing:
* first we say we received a response for previously sent command,
* then we send the next command from the queue,
* and then we handle the received response for previous command.
IMO, it's more logical as it is now.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32552
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibdffa4644aa3a7d219452644d3e74b411734f1df
Gerrit-Change-Number: 32552
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 29 Apr 2023 07:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment