Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email )
Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
IIUC this is not really a fix of a bug, but simply a
code cleanup/improvement right?
No, it fixes parsing ctrl messages over sccplite
when libosmo-sccp/netif uses osmo_io.
Parsing IPAC_PROTO_EXT_MGCP messages is also broken before this patch.
PS1:
The commit message includes: […]
I guess it
depends on the version of libosmo-sigtran in use.
Commit 9257cd896e255403822bee6f87f5487a92fd3c11 there uses osmo_io and calls
osmo_stream_cli_set_segmentation_cb(asp->client, osmo_ipa_segmentation_cb) when the AXP
proto is OSMO_SS7_ASP_PROT_IPA.
Since osmo-bsc reqires libosmo-sigtran >= 1.9.0 which includes this commit this
won't really build with any older version, right?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7
Gerrit-Change-Number: 37662
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jul 2024 12:17:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment