Attention is currently required from: Hoernchen, dexter, laforge.
lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email )
Change subject: smdpp: less verbose by default
......................................................................
Patch Set 11:
(1 comment)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/40468/comment/67edbff9_f2fccd0f?usp=ema... :
PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200])
Ok, but still not related to the change. NOTHING here is about performance.
Maybe it is not about the less than optimal performant. Ok, you could do it in a different commit.
But if you want to replace print() with logger.debug(), please use the logger.debug('foo %s', args) way, which is the intended way of use logger.debug() with such string substitude formats.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40468?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49
Gerrit-Change-Number: 40468
Gerrit-PatchSet: 11
Gerrit-Owner: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 15 Aug 2025 10:25:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen
ewild@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu
