Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30192 )
Change subject: firmware/sniffer: Add + use 16bit ringbuffer ......................................................................
Patch Set 1:
(2 comments)
File firmware/libcommon/include/ringbuffer.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1073): https://gerrit.osmocom.org/c/simtrace2/+/30192/comment/1a973922_030f7d2a PS1, Line 40: typedef struct ringbuf16 { do not add new typedefs
File firmware/libcommon/source/ringbuffer.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1073): https://gerrit.osmocom.org/c/simtrace2/+/30192/comment/2929bf77_9fa9a863 PS1, Line 147: } else { else is not generally useful after a break or return