Attention is currently required from: pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36205?usp=email )
Change subject: Introduce counter for per-hnb cumulative active CS RAB duration
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-hnbgw/hnbgw.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36205/comment/753ff269_b0484ca7
PS3, Line 78: if (!hnb->persistent)
That's for a weird consequence of all the
persistent stuff: […]
I think you're understanding the code wrong. A
'persistent' data structure is always allocated on-demand whenever it does not
exist upon the first connect of the HNB with the related "UMTS CGI-like"
identity.
So every hnb_context will always have a "persistent" struct associated with it
after the HNB-REGISTER-ACCEPT.
"persistent" just means that the data persists across re-connect.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36205?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iffb6a3f38239094551a12c872cd8474d02a5ad56
Gerrit-Change-Number: 36205
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Mar 2024 20:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment