Attention is currently required from: fixeria, laforge, lynxis lazus.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email )
Change subject: msc: add TC_silent_call_{start_stop,active_conn}
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
File msc/MSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/fcbff9f6_418d…
:
PS4, Line 7720: cmd := "subscriber imsi " & hex2str(g_pars.imsi) &
" silent-call ";
I'd better enclose this into a helper function so we only need to change it in one
place if we ever change the vty command.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/f8546d82_390d…
:
PS4, Line 7726: MSCVTY.send(cmd & "start any signalling");
the "start any signalling" and the wait below can also be part of the function
call.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863/comment/fbe3436b_b8ae…
:
PS4, Line 7750: MSCVTY.send(cmd & "stop");
this can also be a helper function.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40863?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3ef22fbb5a05f69cc8aea7f42e05f6e1d6c4a8b6
Gerrit-Change-Number: 40863
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 18 Aug 2025 09:40:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes