Attention is currently required from: laforge, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 )
Change subject: immediately SCCP RLSD on HNB re-register
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Ok, but I think you didn't mention the
RUA_Disconnect message there, now it's clearer.
/me adds "RUA" to
commit msg
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/3e0d8a16_714e474c
PS1, Line 362: tx_sccp_df1(fi, ranap_msg);
: tx_sccp_rlsd(fi);
I think "dispatch" or "submit" are
better candidates than "transmit" or "send" when passing stuff ac […]
ok. i'm still a bit unclear, is this about only tx_sccp_rlsd() or also the other
one?
in my POV both functions already have the best names -- they both transmit actual SCCP
packets on the wire, by asking the SCCP user sap. So may I ask reviewers to just tell me
which function(s) to rename to exactly what and I can do that.
In every case that would happen in a separate patch. If there's no opposition, I'm
going to click on 'Resolved' here, from the perspective of review on the changes
of *this* patch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I4e78617ad39bb73fe92097c8a1a8069da6a7f6a1
Gerrit-Change-Number: 32915
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 May 2023 21:20:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment