Attention is currently required from: laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915 )
Change subject: immediately SCCP RLSD on HNB re-register ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
Ok, but I think you didn't mention the RUA_Disconnect message there, now it's clearer.
/me adds "RUA" to commit msg
File src/osmo-hnbgw/context_map_sccp.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32915/comment/3e0d8a16_714e474c PS1, Line 362: tx_sccp_df1(fi, ranap_msg); : tx_sccp_rlsd(fi);
I think "dispatch" or "submit" are better candidates than "transmit" or "send" when passing stuff ac […]
ok. i'm still a bit unclear, is this about only tx_sccp_rlsd() or also the other one?
in my POV both functions already have the best names -- they both transmit actual SCCP packets on the wire, by asking the SCCP user sap. So may I ask reviewers to just tell me which function(s) to rename to exactly what and I can do that.
In every case that would happen in a separate patch. If there's no opposition, I'm going to click on 'Resolved' here, from the perspective of review on the changes of *this* patch.