Attention is currently required from: laforge, pespin.

2 comments:

Patchset:
- Patch Set #1:
  Ok, but I think you didn't mention the RUA_Disconnect message there, now it's clearer.
  /me adds "RUA" to commit msg
File src/osmo-hnbgw/context_map_sccp.c:
- Patch Set #1, Line 362:
```
tx_sccp_df1(fi, ranap_msg);
		tx_sccp_rlsd(fi);
```
  I think "dispatch" or "submit" are better candidates than "transmit" or "send" when passing stuff ac […]
  ok. i'm still a bit unclear, is this about only tx_sccp_rlsd() or also the other one?
  in my POV both functions already have the best names -- they both transmit actual SCCP packets on the wire, by asking the SCCP user sap. So may I ask reviewers to just tell me which function(s) to rename to exactly what and I can do that.
  In every case that would happen in a separate patch. If there's no opposition, I'm going to click on 'Resolved' here, from the perspective of review on the changes of *this* patch.

To view, visit change 32915. To unsubscribe, or for help writing mail filters, visit settings.