Attention is currently required from: csaba.sipos, domi, laforge.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )
Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes
......................................................................
Patch Set 22:
(1 comment)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/63d535d3_115d6af6?usp=... :
PS21, Line 1860: !FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) {
Could you all please look at Patchset 22, I tried correcting everything. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3
Gerrit-Change-Number: 39416
Gerrit-PatchSet: 22
Gerrit-Owner: csaba.sipos
metro4@freemail.hu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: domi
domi@tomcsanyi.net
Gerrit-Attention: csaba.sipos
metro4@freemail.hu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: domi
domi@tomcsanyi.net
Gerrit-Comment-Date: Tue, 11 Feb 2025 12:31:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos
metro4@freemail.hu
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: domi
domi@tomcsanyi.net