fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39951?usp=email )
Change subject: msc: expect network-originated MT_FORWARD_SM_ERR
......................................................................
msc: expect network-originated MT_FORWARD_SM_ERR
In both testcase scenarios we expect the network to indicate the
MT_FORWARD_SM_ERROR on its own, due to the lack of response from MS/UE.
Use the right template kind for that, expect a specific Cause value.
Change-Id: Ic27d943645fdff8d34f958e3bf16c8ee6e8368d2
Related: e9de1515 ("msc: add TC_gsup_mt_sms_{paging,conn}_timeout")
Related: SYS#7323
---
M msc/MSC_Tests.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/51/39951/1
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 40cd9fd..492a551 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -3297,6 +3297,7 @@
/* Test sending of GSUP MT-forwardSM-Err if MS does not respond to paging */
friend function f_TC_gsup_mt_sms_paging_timeout(charstring id, BSC_ConnHdlrPars pars)
runs on BSC_ConnHdlr {
+ const integer cause := 17; /* GMM_CAUSE_NET_FAIL */
var SmsParameters spars := valueof(t_SmsPars);
var boolean released := false;
timer T;
@@ -3321,9 +3322,8 @@
T.start(10.0 + 2.0); /* X4 + 2 seconds */
alt {
/* Expect the MSC to indicate an error after paging timeout
- * TODO: expect a specific SM-RP-Cause value
* XXX: should we expect SM-RP-REF to be 'FF'O? */
- [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_ERR(g_pars.imsi, ?, ?));
+ [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_ERR_NET(g_pars.imsi, ?, cause));
[] as_unexp_gsup_msg();
[] as_unexp_bssap_msg();
[] T.timeout {
@@ -3343,6 +3343,7 @@
/* Test sending of GSUP MT-forwardSM-Err if MS does not send RP-ACK */
friend function f_TC_gsup_mt_sms_conn_timeout(charstring id, BSC_ConnHdlrPars pars)
runs on BSC_ConnHdlr {
+ const integer cause := 17; /* GMM_CAUSE_NET_FAIL */
var SmsParameters spars := valueof(t_SmsPars);
var boolean released := false;
timer T;
@@ -3372,9 +3373,8 @@
T.start(5.0 + 2.0); /* X1 + 2 seconds */
alt {
/* Expect the MSC to indicate an error after connection timeout
- * TODO: expect a specific SM-RP-Cause value
* XXX: should we expect SM-RP-REF to be 'FF'O? */
- [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_ERR(g_pars.imsi, ?, ?));
+ [] GSUP.receive(tr_GSUP_MT_FORWARD_SM_ERR_NET(g_pars.imsi, ?, cause));
/* Timeout of X1 (5s) will trigger connection release */
[not released] as_expect_clear() {
released := true;
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39951?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic27d943645fdff8d34f958e3bf16c8ee6e8368d2
Gerrit-Change-Number: 39951
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>